Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compress png files #1494

Merged
merged 4 commits into from
May 27, 2020
Merged

Compress png files #1494

merged 4 commits into from
May 27, 2020

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented May 25, 2020 •
edited
Loading

PR Description

Lossless compression of PNGs

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo dcoeurjo mentioned this pull request May 25, 2020
Closed
phcerdan
phcerdan previously approved these changes May 25, 2020
View reviewed changes
@dcoeurjo dcoeurjo added this to the 1.1 milestone May 25, 2020
kerautret
kerautret previously approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 nice, looks fine with the changelog

@kerautret kerautret merged commit 86f5a58 into DGtal-team:master May 27, 2020
@dcoeurjo dcoeurjo deleted the PNGClean branch October 7, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

@phcerdan phcerdan phcerdan left review comments

Assignees
No one assigned
Labels
Documentation ready for review 👍
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dcoeurjo @kerautret @phcerdan